Add kern.features.cheri_purecap_kernel #2229
Conversation
|
Nothing in tree uses the old feature flag so I think it's safe to drop. Could keep it for a release instead, but we'd then need to remember to remove it. |
There was a problem hiding this comment.
It might be worth renaming other features to match kernel config options and indicate that they refer to CHERI/Morello:
kern.features.subobject_boundstokern.features.cheri_subobject_boundskern.features.cheri_revoketokern.features.cheri_caprevokekern.features.benchmark_abi_kerneltokern.features.morello_benchmarkabi_kernel.
That would be useful when listing features with sysctl kern.features | grep 'cheri\|morello'.
This doesn't say purecap in it. Given we have cheri_purecap_kernel, probably morello_purecap_benchmark_kernel is the best thing (with a possible _abi in there too if you want). |
This one is queried by bits of userspace, so an upgraded kernel would break them. |
This should say kernel in it too for the feature name? |
brooksdavis
force-pushed
the
features.cheri_purecap_kernel
branch
from
21c47d0 to
0203c36
Compare
This would be mostly harmless and transient if we fixed userspace. It's used to suppress some warnings in libprocstat when the feature is missing and as well as skip some cheribsdtest tests so there would be a modest incompatibility between mismatched kernel and userspace but not critical breakage. |
|
I've left kern.features.cheri_revoke alone for now, but I think we should land the other changes. |
Rename misleading kern.features.cheriabi_kernel to kern.features.cheri_purecap_kernel and make clear that it's a pure-capability kernel (not CheriABI which refers to userspace).
subobject_bounds -> cheri_subobject_bounds_kernel benchmark_abi_kernel -> morello_purecap_benchmark_abi_kernel Make it clear that these are kernel things and that subobject bounds is related to CHERI.
bsdjhb
force-pushed
the
features.cheri_purecap_kernel
branch
from
0203c36 to
1964c0b
Compare
Rename misleading kern.features.cheriabi_kernel to kern.features.cheri_purecap_kernel and make clear that it's a pure-capaiblity kernel (not CheriABI which refers to userspace).